linux-kernel - Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Oct 2015 12:07:41 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent

On Fri 02 Oct 10:47 PDT 2015, Dmitry Torokhov wrote:

> On Mon, Jul 27, 2015 at 06:50:18PM -0700, Bjorn Andersson wrote:
> > As gpio_keys_setup_key() only operates on the device, pass a pointer to
> > this from the probe instead of a platform_device and make the usage
> > consistent. Also make probe() more consistent by dropping the local copy
> > of the device pointer.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>
> 
> Don't really see the difference either way... We trade &pdev->dev for
> dev in one place and trade dev for &pdev->dev in another. I'd rather
> skip it.
> 
> Thanks.
> 

No worries, my dislike of the mixing of the two uses within the first
function was enough to hack up a patch - feel free to drop it as you
don't think it's worth the churn.


Thanks for merging the error handling patch though.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/