linux-kernel - Re: [PATCH] perf: change samples type to unsigned long long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151002190838.GE12682@redhat.com>
Date:	Fri, 2 Oct 2015 16:08:38 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Yang Shi <yang.shi@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	acme@...nel.org
Subject: Re: [PATCH] perf: change samples type to unsigned long long

Em Tue, Sep 29, 2015 at 02:49:43PM -0700, Yang Shi escreveu:
> When run "perf record -e", the number of samples showed up is wrong on some
> 32 bit systems, i.e. powerpc and arm.
> 
> For example, run the below commands on 32 bit powerpc:
> 
> perf probe -x /lib/libc.so.6 malloc
> perf record -e probe_libc:malloc -a ls
> perf.data
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.036 MB perf.data (13829241621624967218 samples) ]
> 
> Actually, "perf script" just shows 21 samples. The number of samples is also
> absurd since samples is long type, but it is printed as PRIu64.
> 
> Build test is run on x86-64, x86, aarch64, arm, mips, ppc and ppc64.

Sure?

  AR       /tmp/build/perf/libperf.a
builtin-record.c: In function ‘__cmd_record’:
builtin-record.c:689:12: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]

- Arnaldo
 
> Signed-off-by: Yang Shi <yang.shi@...aro.org>
> ---
>  tools/perf/builtin-record.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 142eeb3..e54aa4c 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -49,7 +49,7 @@ struct record {
>  	int			realtime_prio;
>  	bool			no_buildid;
>  	bool			no_buildid_cache;
> -	long			samples;
> +	unsigned long long	samples;
>  };
>  
>  static int record__write(struct record *rec, void *bf, size_t size)
> -- 
> 2.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/