linux-kernel - Re: [PATCH v2 5/7] 9p: xattr simplifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151004062709.GD28519@infradead.org>
Date:	Sat, 3 Oct 2015 23:27:09 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Andreas Gruenbacher <agruenba@...hat.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Eric Van Hensbergen <ericvh@...il.com>,
	Ron Minnich <rminnich@...dia.gov>,
	Latchesar Ionkov <lucho@...kov.net>,
	v9fs-developer@...ts.sourceforge.net
Subject: Re: [PATCH v2 5/7] 9p: xattr simplifications

On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote:
>  
> +/**
> + * xattr_full_name  -  Compute full attribute name from suffix
> + *

Missing argument descriptions for a kdoc comment.

> +const char *xattr_full_name(const struct xattr_handler *handler,
> +			    const char *name)
> +{
> +	size_t prefix_len = strlen(handler->prefix);
> +
> +	/* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */

This either should be a real WARN_ON or go away.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/