linux-kernel - Re: [PATCH v2 6/7] squashfs: xattr simplifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151004062906.GE28519@infradead.org>
Date:	Sat, 3 Oct 2015 23:29:06 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Andreas Gruenbacher <agruenba@...hat.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Phillip Lougher <phillip@...ashfs.org.uk>
Subject: Re: [PATCH v2 6/7] squashfs: xattr simplifications

On Tue, Sep 22, 2015 at 02:26:51PM +0200, Andreas Gruenbacher wrote:
> Now that the xattr handler is passed to the xattr handler operations, we
> have access to the attribute name prefix, so simplify the squashfs xattr
> handlers a bit.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> ---
>  fs/squashfs/xattr.c | 90 ++++++++++++++++++-----------------------------------
>  1 file changed, 31 insertions(+), 59 deletions(-)
> 
> diff --git a/fs/squashfs/xattr.c b/fs/squashfs/xattr.c
> index 4ae1e4f..6a4cc34 100644
> --- a/fs/squashfs/xattr.c
> +++ b/fs/squashfs/xattr.c
> @@ -212,96 +212,68 @@ failed:
>  }
>  
>  
> -/*
> - * User namespace support
> - */
> -static size_t squashfs_user_list(const struct xattr_handler *handler,
> -				 struct dentry *d, char *list, size_t list_size,
> -				 const char *name, size_t name_len)
> +static size_t squashfs_xattr_handler_list(const struct xattr_handler *handler,
> +					  struct dentry *d, char *list,
> +					  size_t list_size, const char *name,
> +					  size_t name_len)
>  {
> -	if (list && XATTR_USER_PREFIX_LEN <= list_size)
> -		memcpy(list, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN);
> -	return XATTR_USER_PREFIX_LEN;
> +	int len = strlen(handler->prefix);
> +
> +	if (list && len <= list_size)
> +		memcpy(list, handler->prefix, len);
> +	return len;

IS it just me or is this handler broke before and after this patch? It
only copies out the prefix, but not the actual xattr name.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/