linux-kernel - Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151004101019.GA23448@kroah.com>
Date:	Sun, 4 Oct 2015 11:10:19 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	rachel.kim@...el.com, devel@...verdev.osuosl.org,
	chris.park@...el.com, linux-wireless@...r.kernel.org,
	johnny.kim@...el.com, linux-kernel@...r.kernel.org,
	Chandra S Gorentla <csgorentla@...il.com>
Subject: Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for
 error cases

On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote:
> > Aren't you now leaking memory as you aren't freeing pstrMessage and the
> > buffer on the "normal" return path?
> 
> It's supposed to.  It's a bug fix.  I explained to him in the first
> version that his changelog sucks.

Ok, well, it still sucks :)

And it's out of my queue, so I'll wait for the next spin of this
series...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/