linux-kernel - Re: [PATCH] staging: rdma: Fix braces around if/else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151004101145.GB23448@kroah.com>
Date:	Sun, 4 Oct 2015 11:11:45 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Martin Kletzander <mkletzan@...hat.com>
Cc:	devel@...verdev.osuosl.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Mike Marciniszyn <infinipath@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Sean Hefty <sean.hefty@...el.com>
Subject: Re: [PATCH] staging: rdma: Fix braces around if/else

On Sun, Oct 04, 2015 at 11:05:50AM +0200, Martin Kletzander wrote:
> On Sun, Oct 04, 2015 at 08:20:09AM +0100, Greg Kroah-Hartman wrote:
> >On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote:
> >>On 10/3/2015 11:55 PM, Martin Kletzander wrote:
> >>>Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.
> >>
> >>Hi Greg,
> >>
> >>Is there a way to signal people/tools that a certain driver parks in staging
> >>on their way **out** of the kernel
> >>and not the other way around? I guess you (nor Doug) don't want to spend
> >>time on fixing such drivers, right?
> >
> >I'm not spending the time :)
> >
> >But no, there isn't a way to really show that that I know of, and it's
> >fine, we end up getting a number of "cleanup" patches for a kernel
> >release or two before the drivers get deleted.  It gets people involved
> >in kernel development which is the key thing here, it's not like they
> >are actually using these drivers...
> >
> >So it's fine, I take the patches, the people writing the patches are
> >happy, and the code gets a bit nicer and feels better about itself
> >before we kick it out the door.
> >
> 
> I didn't mean to waste anyone's time on this.  I'm just trying to get
> more familiar with the patch submission process into the kernel.  And
> I'm doing this in my free time despite the address used.  I probably
> should've noted that below to commit message.

No need to say _why_ you are sending kernel patches, I don't care :)

And this is a great way to get familiar with the process, it's why there
are so many things in the drivers/staging/ tree to fix up.  If we really
wanted to get the code "correct", I would just take a few days and fix
it all up myself, but that's not the goal here.

Keep it up, you are doing just fine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/