linux-kernel - Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151005094435.GI12635@sirena.org.uk>
Date:	Mon, 5 Oct 2015 10:44:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Emilio Lopez <emilio@...pez.com.ar>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing

On Sun, Oct 04, 2015 at 03:38:16PM +0200, Maxime Ripard wrote:

> Most of the boards have their headphone jack directly connected to the
> matching pins of the SoCs. Since most of the time we will have the same
> routing path, it makes sense to put that in the driver, and only have a
> property describing whether that route is enabled or not.

What is the value in having just a dumb jack with no detection
configured?  It doesn't actually do anything...

> It also fixes the following warning messages that were seen so far:
> sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Left -> direct -> Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Right -> direct -> Headphone Jack

Why are these routes being added separately to adding the jack?  Just
remove the broken routes.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)