linux-kernel - Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151005102550.GI2696@lukather>
Date:	Mon, 5 Oct 2015 12:25:50 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Emilio Lopez <emilio@...pez.com.ar>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing

Hi Mark,

On Mon, Oct 05, 2015 at 10:44:35AM +0100, Mark Brown wrote:
> On Sun, Oct 04, 2015 at 03:38:16PM +0200, Maxime Ripard wrote:
> 
> > Most of the boards have their headphone jack directly connected to the
> > matching pins of the SoCs. Since most of the time we will have the same
> > routing path, it makes sense to put that in the driver, and only have a
> > property describing whether that route is enabled or not.
> 
> What is the value in having just a dumb jack with no detection
> configured?  It doesn't actually do anything...

Well, it's how it's wired on most boards. The jack is directly
connected to the SoC, without any detection mechanism, not even a
GPIO, so we can only assume it's always there if we want it to work
properly.

> > It also fixes the following warning messages that were seen so far:
> > sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> > sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Left -> direct -> Headphone Jack
> > sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> > sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Right -> direct -> Headphone Jack
> 
> Why are these routes being added separately to adding the jack?  Just
> remove the broken routes.

I'm not sure I understand here. The former DT bindings example was
adding this route, which was broken because of the missing output
widget for the headphone jack.

My patch here adds both if the DT says that the headphone jack is
actually used on that board, so it should fix both issues: no broken
route, and no missing widgets. right?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)