linux-kernel - RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B3D45F060@hasmsx108.ger.corp.intel.com>
Date:	Mon, 5 Oct 2015 14:47:35 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"Usyskin, Alexander" <alexander.usyskin@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Alexander Kuleshov" <kuleshovmail@...il.com>
Subject: RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

> 
> On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> > From: Alexander Kuleshov <kuleshovmail@...il.com>
> >
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > ---
> > V2: fixed author address
> >
> >  drivers/misc/mei/debugfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> > index 4b469cf9e60f..c157f0ba575c 100644
> > --- a/drivers/misc/mei/debugfs.c
> > +++ b/drivers/misc/mei/debugfs.c
> > @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const
> char *name)
> >  	f = debugfs_create_file("active", S_IRUSR, dir,
> >  				dev, &mei_dbgfs_fops_active);
> >  	if (!f) {
> > -		dev_err(dev->dev, "meclients: registration failed\n");
> > +		dev_err(dev->dev, "active: registration failed\n");
> >  		goto err;
> 
> You should never care if a debugfs call fails or not.

The system should not be dependent on the debug feature but, it is always good to know if there our system is failing 

  Also, this will
> "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
> using the api wrong :(

The whole file is not compiled if CONFIG_DEBUGFS is not set, please see the Makefile 


Thanks
Tomas 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/