linux-kernel - Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Oct 2015 16:30:36 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>
Cc:	"Usyskin, Alexander" <alexander.usyskin@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexander Kuleshov <kuleshovmail@...il.com>
Subject: Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

On Mon, Oct 05, 2015 at 02:47:35PM +0000, Winkler, Tomas wrote:
> > 
> > On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> > > From: Alexander Kuleshov <kuleshovmail@...il.com>
> > >
> > > Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > > ---
> > > V2: fixed author address
> > >
> > >  drivers/misc/mei/debugfs.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> > > index 4b469cf9e60f..c157f0ba575c 100644
> > > --- a/drivers/misc/mei/debugfs.c
> > > +++ b/drivers/misc/mei/debugfs.c
> > > @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const
> > char *name)
> > >  	f = debugfs_create_file("active", S_IRUSR, dir,
> > >  				dev, &mei_dbgfs_fops_active);
> > >  	if (!f) {
> > > -		dev_err(dev->dev, "meclients: registration failed\n");
> > > +		dev_err(dev->dev, "active: registration failed\n");
> > >  		goto err;
> > 
> > You should never care if a debugfs call fails or not.
> 
> The system should not be dependent on the debug feature but, it is
> always good to know if there our system is failing 

And what can you do if it is "failing"?  Really nothing, so there's
nothing to check here.

>   Also, this will
> > "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
> > using the api wrong :(
> 
> The whole file is not compiled if CONFIG_DEBUGFS is not set, please see the Makefile 

Ok, then you don't need to check anything.  Debugfs was created to be
dirt-simple, don't add complexity and "must unwind cleanly" type logic
here where it's not needed at all.  That just hurts my sensibilities for
why I made the API the way it is in the first place :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/