| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151005152628.GE13501@vkoul-mobl.iind.intel.com> Date: Mon, 5 Oct 2015 16:26:30 +0100 From: Vinod Koul <vinod.koul@...el.com> To: Kedareswara rao Appana <appana.durga.rao@...inx.com> Cc: dan.j.williams@...el.com, michal.simek@...inx.com, soren.brinkmann@...inx.com, moritz.fischer@...us.com, appanad@...inx.com, anirudha@...inx.com, dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v9] dmaengine: Add Xilinx AXI Direct Memory Access Engine driver support On Mon, Aug 24, 2015 at 09:41:06PM +0530, Kedareswara rao Appana wrote: > This is the driver for the AXI Direct Memory Access (AXI DMA) > core, which is a soft Xilinx IP core that provides high- > bandwidth direct memory access between memory and AXI4-Stream > type target peripherals. Okay reviewing this after the other Xilinx driver with very similar name, I am very concerned about code duplication. Both codes seems to be pretty much copy paste and some modifications for IP. In Linux kernel we reuse! Please create common lib for Xilinx drivers to use and have HW diff is two drivers, or manage those with different driver ops Pls justify why we should have two drivers. Looking at code makes me think otherwise -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists