linux-kernel - Re: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151005155543.GY12635@sirena.org.uk>
Date:	Mon, 5 Oct 2015 16:55:43 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver

On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote:

> This patch adds support for DT bindings in the codec driver.
> As part of this support, the mclk data can now be provided and
> used to control the mclk during codec operation.

Please split out the new MCLK configuration into a separate patch which
describes what that configuration is, it's much easier to review that
way.  Otherwise there's a couple of minor issues here but nothing too
critical.

>  	case SND_SOC_BIAS_STANDBY:
>  		if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) {
> +			/* MCLK */
> +			clk_prepare_enable(da7213->mclk);
> +

This doesn't check the return value.

>  	.driver = {
>  		.name = "da7213",
> +		.of_match_table = da7213_of_match,

Please use of_match_ptr() here.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)