lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 05 Oct 2015 22:27:20 +0100
From:	Bryan O'Donoghue <>
To:	"Kweh, Hock Leong" <>,
	Borislav Petkov <>
CC:	Matt Fleming <>,
	Greg Kroah-Hartman <>,
	"Ong, Boon Leong" <>,
	LKML <>,
	"" <>,
	Sam Protsenko <>,
	Peter Jones <>,
	Andy Lutomirski <>,
	Roy Franz <>,
	James Bottomley <>,
	Linux FS Devel <>,
	"Fleming, Matt" <>
Subject: Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

On 05/10/15 16:19, Kweh, Hock Leong wrote:
>> -----Original Message-----
>> From: Borislav Petkov []
>> Sent: Monday, October 05, 2015 9:14 PM
>> So this one is still a separate patch.
>> If you're going to ignore review comments, maybe I should stop wasting my
>> time reviewing your stuff...
>> --
>> Regards/Gruss,
>>      Boris.
> Already follow what you have suggested, put a note under --- line:
> (at line 25 - 27)
> Thanks for the review comments.

Wilson - trying to test this out on a Galileo Gen2 - which branch are 
you doing this against ?

I can apply the first patch you're proposing to squash your commit into

but then trying to apply the first in your series on top of that patch I get

deckard@...eko:~/Development/linux$ git apply 
../patches/capsule_wilson/1_2.eml:72: trailing whitespace.
error: drivers/firmware/efi/capsule.c: No such file or directory 


If so - then why not use the interface here ?

(Sorry I know I'm coming to this thread late)

Aside from that, I'm curious which types of capsules you've used here 
too - does it include the MFH header ? Keep in mind the initial firmware 
that shipped with Galileo will depend on that MFH being present. 
- Section A1 - table 7 ?

So if we boot a 4.x kernel with that initial firmware version 0.75 if 
memory serves - it's important that the capsule.c code handles the MFH.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists