linux-kernel - Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151006094040.GA24624@infradead.org>
Date:	Tue, 6 Oct 2015 02:40:40 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Lee Duncan <lduncan@...e.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Tejun Heo <tj@...nel.org>, Hannes Reinecke <hare@...e.com>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index
 management

>  struct Scsi_Host *scsi_host_lookup(unsigned short hostnum)
>  {
> -	struct device *cdev;
> -	struct Scsi_Host *shost = NULL;
> -
> -	cdev = class_find_device(&shost_class, NULL, &hostnum,
> -				 __scsi_host_match);
> -	if (cdev) {
> -		shost = scsi_host_get(class_to_shost(cdev));
> -		put_device(cdev);
> -	}
> +	struct Scsi_Host *shost;
> +
> +	spin_lock(&host_index_lock);
> +	shost = idr_find(&host_index_idr, hostnum);
> +	spin_unlock(&host_index_lock);
> +
>  	return shost;

How does this actually grab a reference to the host?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/