lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Oct 2015 11:43:36 +0200 From: Christoph Hellwig <hch@....de> To: Akinobu Mita <akinobu.mita@...il.com> Cc: Christoph Hellwig <hch@....de>, LKML <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>, Ming Lei <tom.leiming@...il.com> Subject: Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map On Tue, Oct 06, 2015 at 08:50:47AM +0900, Akinobu Mita wrote: > 2015-09-29 15:52 GMT+09:00 Christoph Hellwig <hch@....de>: > > Looks good, > > > > Reviewed-by: Christoph Hellwig <hch@....de> > > > > Can you also add a patch that renames blk_mq_free_queue to > > blk_mq_cleaup_queue and adds a comment that we should not free any memory > > here? We had way too many bugs of this kinds unfortunately. > > Renaming blk_mq_free_queue to blk_mq_cleaup_queue sounds good because > it is called from blk_cleanup_queue(). > > How about adding comment like below? This looks great. It's a lot more than what I though but it looks correct and useful! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists