linux-kernel - Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151006105907.GM12635@sirena.org.uk>
Date:	Tue, 6 Oct 2015 11:59:07 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jiada Wang <jiada_wang@...tor.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software
 reset in pm_resume

On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote:

> +	/* All registers have been reset to default value without calling
> +	 * to regmap interface, even if reset fails, some registers
> +	 * maybe in intermediate status, so we need to mark regmap
> +	 * cache_dirty flag.
> +	 */
> +	regcache_mark_dirty(wm8962->regmap);

This is a standard thing that applies to almost all devices, there
should be no need for such an extensive comment (which would normally
flag up that there's something weird and surprising going on).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)