lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Oct 2015 16:47:59 +0200 From: Gregory CLEMENT <gregory.clement@...e-electrons.com> To: Marcin Wojtas <mw@...ihalf.com> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org, ulf.hansson@...aro.org, sebastian.hesselbarth@...il.com, andrew@...n.ch, jason@...edaemon.net, thomas.petazzoni@...e-electrons.com, nadavh@...vell.com, alior@...vell.com, tawfik@...vell.com, jaz@...ihalf.com, <stable@...r.kernel.org> Subject: Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Hi Marcin, On mar., oct. 06 2015, Marcin Wojtas <mw@...ihalf.com> wrote: > In case of armada_38x_quirks error, all clocks should be cleaned-up, same > as after mv_conf_mbus_windows failure. > > Signed-off-by: Marcin Wojtas <mw@...ihalf.com> > Cc: <stable@...r.kernel.org> # v4.2 Good catch. Reviewed-by: Gregory CLEMENT <gregory.clement@...e-electrons.com> Thanks, Gregory > --- > drivers/mmc/host/sdhci-pxav3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index 89a9e49..f5edf9d 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -402,7 +402,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) > if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) { > ret = armada_38x_quirks(pdev, host); > if (ret < 0) > - goto err_clk_get; > + goto err_mbus_win; > ret = mv_conf_mbus_windows(pdev, mv_mbus_dram_info()); > if (ret < 0) > goto err_mbus_win; > -- > 1.8.3.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists