lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Oct 2015 17:27:57 +0200 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Bart Van Assche <bart.vanassche@...disk.com> Cc: Christoph Hellwig <hch@...radead.org>, Hannes Reinecke <hare@...e.de>, "James E.J. Bottomley" <JBottomley@...n.com>, <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file On Mon, Oct 05 2015, Bart Van Assche <bart.vanassche@...disk.com> wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> - {0x041A, "Logical unit not ready, start stop unit command in " >> - "progress"}, >> - {0x041B, "Logical unit not ready, sanitize in progress"}, >> - {0x041C, "Logical unit not ready, additional power use not yet " >> - "granted"}, > > Please convert these multi-line strings into single line string > constants such that users can look up these easily with grep. I can certainly do that, but I'd prefer to do it in a separate patch. I really want to keep this as mechanical as possible. >> + >> +SENSE_CODE(0, NULL) > > The above looks confusing to me. Please leave this out and add { 0, > NULL } at the end of the additional[] array instead. OK, I agree that that would have been cleaner. However, the sentinel entry is removed in 2/2 (since we loop using ARRAY_SIZE instead of checking for the sentinel). Let me know if you want me to resend the 1600 line monster anyway with this addressed. Thanks, Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists