lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Oct 2015 17:31:29 +0200 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Bart Van Assche <bart.vanassche@...disk.com> Cc: Christoph Hellwig <hch@...radead.org>, Hannes Reinecke <hare@...e.de>, "James E.J. Bottomley" <JBottomley@...n.com>, <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k On Mon, Oct 05 2015, Bart Van Assche <bart.vanassche@...disk.com> wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> struct error_info { >> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ >> - const char * text; >> + unsigned short size; >> }; > > Had you considered to use the type uint16_t instead of unsigned short ? > Yes, but I thought I'd keep it consistent with the other member. AFAIK, they're one and the same on all relevant arches. I actually think spelling it u16 for both members would make sense (for the code because it explicitly is meant to hold two bytes), but again I think that's better done as a trivial follow-up patch, if we really want to change this. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists