linux-kernel - Re: [PATCH v2 3/3] strscpy: zero any trailing garbage bytes in the destination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007073152.GA8974@gmail.com>
Date:	Wed, 7 Oct 2015 09:31:52 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Chris Metcalf <cmetcalf@...hip.com>
Cc:	Michael Cree <mcree@...on.net.nz>,
	Matt Turner <mattst88@...il.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
	linux-alpha@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] strscpy: zero any trailing garbage bytes in the
 destination


* Chris Metcalf <cmetcalf@...hip.com> wrote:

> It's possible that the destination can be shadowed in userspace
> (as, for example, the perf buffers are now).  So we should take
> care not to leak data that could be inspected by userspace.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@...hip.com>

Please always preserve credits for who found the bug:

  Reported-by: Alexey Dobriyan <adobriyan@...il.com>

Also, you should credit the kbuild-bot for the cross-arch build breakages that 
your other patches address:

  Reported-by: kbuild test robot <fengguang.wu@...el.com>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/