lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <561524FF.20807@ezchip.com> Date: Wed, 7 Oct 2015 09:58:23 -0400 From: Chris Metcalf <cmetcalf@...hip.com> To: Ingo Molnar <mingo@...nel.org> CC: Michael Cree <mcree@...on.net.nz>, Matt Turner <mattst88@...il.com>, Michael Ellerman <mpe@...erman.id.au>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Alexey Dobriyan <adobriyan@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Linus Torvalds <torvalds@...ux-foundation.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>, <linux-alpha@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/3] word-at-a-time.h: support zero_bytemask() on alpha and tile On 10/07/2015 01:53 AM, Ingo Molnar wrote: > * Chris Metcalf <cmetcalf@...hip.com> wrote: > >> Both alpha and tile needed implementations of zero_bytemask. >> >> The alpha version is untested. >> >> Signed-off-by: Chris Metcalf <cmetcalf@...hip.com> >> --- >> arch/alpha/include/asm/word-at-a-time.h | 2 ++ >> arch/tile/include/asm/word-at-a-time.h | 8 +++++++- >> 2 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/arch/alpha/include/asm/word-at-a-time.h b/arch/alpha/include/asm/word-at-a-time.h >> index 6b340d0f1521..902e6ab00a06 100644 >> --- a/arch/alpha/include/asm/word-at-a-time.h >> +++ b/arch/alpha/include/asm/word-at-a-time.h >> @@ -52,4 +52,6 @@ static inline unsigned long find_zero(unsigned long bits) >> #endif >> } >> >> +#define zero_bytemask(mask) ((2ul << (find_zero(mask) * 8)) - 1) > Small nit: please use a proper C inline function instead of CPP, as for example > the PowerPC zero_bytemask() function is. Indeed, I normally would do that. But, I was trying to match the existing style; there are nine definitions that are specified as macros (including the one in asm-generic), and only one (powerpc 64-bit LE) that was specified as an inline. I did put together a v3 of the patch series that included all your excellent suggestions, including the Reported-by, Tested-by, and Reviewed-by tags, but then found out v2 was already pulled into Linus's tree, so I guess that ship has sailed; oh well. My inclination would be not to churn the tree with a patch to convert those new zero_bytemask() macros to inlines, but I'm happy to do so if you think it would be better. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists