linux-kernel - Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007092714.GZ12635@sirena.org.uk>
Date:	Wed, 7 Oct 2015 10:27:14 +0100
From:	Mark Brown <broonie@...nel.org>
To:	sugar <sugar.zhang@...k-chips.com>
Cc:	alsa-devel@...a-project.org, heiko@...ech.de,
	linux-kernel@...r.kernel.org, tiwai@...e.com, lgirdwood@...il.com,
	linux-rockchip@...ts.infradead.org, perex@...ex.cz,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and
 lrck-mode support

On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
> 在 10/1/2015 02:46, Mark Brown 写道:

> >What makes you say that the symmetric_rates flag can't be used to cover
> >this case?  What you describe above is hte normal reason for needing to
> >enforce symmetric_rates.  The driver should be able to check if the flag
> >has been set just as well as the core is.

> Got it, How about the following modify?

> if (dai->symmetric_rates)
> 	regmap_update_bits(i2s->regmap, I2S_CKR,
>                            I2S_CKR_TRCM_MASK,
>                            I2S_CKR_TRCM(val));

Yes, something like that.  You'll need to check both links in the DAI
and the DAI link itself rather than just your own DAI but we should have
a helper function for that - I'll add one, look out for a patch shortly.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)