linux-kernel - Re: ver_linux: proposed implementation feedback request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007012506.GA24678@thunk.org>
Date:	Tue, 6 Oct 2015 21:25:06 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Alexander Kapshuk <alexander.kapshuk@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Jim Davis <jim.epost@...il.com>, richard@....at,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: ver_linux: proposed implementation feedback request

On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
> Thanks very much for everyone's feedback.
> 
> Instead of flooding this mailing list with another bunch of ver_linux
> patches, I thought I would post another implementation, and see if you
> find any of the proposed changes worth submitting as a patch. I will
> be happy with whatever feedback you can give me. And we will leave it
> at that. Thanks.

Can you also explain what the changes are that you're making?  That
might be very helpful.

I'm also curious if someone suggested that you break apart the patch
into a separate one for each program?  In my opinion that actually
made it harder to review the patch set (especially when I was cc'ed on
the one for tune2fs, but not the patch that set $tune2fs :-).

My suggestion would be to break it apart by functional changes.  If
the main change is to support different version numbers emitted by a
wide range of version numbers, just say something like: fixed the
version number detection of the FOO, BAR, and BAZ packages.

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/