lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <0291312bcff1d7a22f7cdee69848dfcb@agner.ch> Date: Wed, 07 Oct 2015 16:34:30 -0700 From: Stefan Agner <stefan@...er.ch> To: Brian Norris <computersforpeace@...il.com> Cc: dwmw2@...radead.org, sebastian@...akpoint.cc, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, shawn.guo@...aro.org, kernel@...gutronix.de, boris.brezillon@...e-electrons.com, marb@...at.de, aaron@...tycactus.com, bpringlemeir@...il.com, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, albert.aribaud@...ev.fr, klimov.linux@...il.com, Bill Pringlemeir <bpringlemeir@...ps.com> Subject: Re: [PATCH v12 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support Hi Brian, On 2015-09-29 13:57, Brian Norris wrote: > Pushed this patch to l2-mtd.git, as it looks pretty much good. Although, > I'd like raw read support... > > On Wed, Sep 02, 2015 at 06:06:34PM -0700, Stefan Agner wrote: >> This adds hardware ECC support using the BCH encoder in the NFC IP. >> The ECC encoder supports up to 32-bit correction by using 60 error >> correction bytes. There is no sub-page ECC step, ECC is calculated >> always accross the whole page (up to 2k pages). >> >> Limitations: >> - HW ECC: Only 2K page with 64+ OOB. >> - HW ECC: Only 24 and 32-bit error correction implemented. >> >> Raw writes have been tested using the generic nand_write_page_raw >> implementation. However, raw reads are currently not possible >> because the controller need to know whether we are going to use >> the ECC mode already at NAND_CMD_READ0 command time. At this point >> we do not have the information whether it is a raw read or a >> regular read at driver level... > > Hmm, can you get this in ecc.read_page_raw()? Even just a read_page_raw implementation doesn't help. The controller requires the ECC to be configured at command issue time, and the driver issues the command in the cmdfunc callback. The function nand_do_read_ops calls cmdfunc before ecc.read_page_raw... I could just bail out in the NAND_CMD_READ0 case, and execute the command from within the ecc.read_page_raw callback function. A bit hacky, but that would work. For that case, it would be nicer if cmdfunc somehow provides the information that a raw read is requested, we would have that information in nand_do_read_ops. However, that would need an extension of the cmdfunc interface... Also, not sure how that should look like. -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists