linux-kernel - Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=kRJPxJiOvqsX_cSJzbew0-_-4Y_q_bQioOdknLbKkZ1A@mail.gmail.com>
Date:	Thu, 8 Oct 2015 09:47:57 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Fei Wang <w.f@...wei.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kevin Hilman <khilman@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, bintian.wang@...wei.com,
	xuyiping@...ilicon.com, guodong.xu@...aro.org,
	puck.chen@...ilicon.com, xuwei5@...ilicon.com,
	william.wfei@...il.com, z.liuxinliang@...ilicon.com,
	kong.kongxinwei@...ilicon.com, zhongkaihua@...wei.com,
	haojian.zhuang@...aro.org, jorge.ramirez-ortiz@...aro.org,
	zhangfei.gao@...aro.org
Subject: Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

Hello Fei Wang,

On Wed, Sep 30, 2015 at 1:05 PM, Fei Wang <w.f@...wei.com> wrote:
> Add Hi655x regulator driver.
>
> Signed-off-by: Fei Wang <w.f@...wei.com>
> ---

[snip]

>
> +config REGULATOR_HI655X
> +        tristate "Hisilicon HI655X PMIC regulators support"

The Kconfig symbol is tree state which means it can be built as a module...

> +
> +static const struct of_device_id of_hi655x_regulator_match_tbl[] = {
> +       {
> +               .compatible = "hisilicon,hi655x-regulator-pmic",
> +               .data = &hi655x_regulator_pmic,
> +       },
> +       { /* end */ }
> +};

...but the OF module alias information is not built into the module so
module autoloading won't work.

Please add a MODULE_DEVICE_TABLE(of, of_hi655x_regulator_match_tbl) here.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/