linux-kernel - Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 17:49:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	wangfei <w.f@...wei.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux@....linux.org.uk,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, khilman@...aro.org,
	sameo@...ux.intel.com, lee.jones@...aro.org, lgirdwood@...il.com,
	bintian.wang@...wei.com, xuwei5@...ilicon.com,
	haojian.zhuang@...aro.org, zhangfei.gao@...aro.org,
	guodong.xu@...aro.org, jorge.ramirez-ortiz@...aro.org,
	puck.chen@...ilicon.com, xuyiping@...ilicon.com,
	kong.kongxinwei@...ilicon.com, z.liuxinliang@...ilicon.com,
	william.wfei@...il.com, zhongkaihua@...wei.com
Subject: Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver

On Thu, Oct 08, 2015 at 02:33:06PM +0800, wangfei wrote:
> On 2015/10/1 1:39, Mark Brown wrote:
> > On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> >> +                coul: coul@1 {
> >> +                        compatible = "hisilicon,hi655x-coul";
> >> +                        interrupt-parent = <&pmic>;
> >> +                        interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
> >> +                        interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i";
> >> +                        battery_product_index = <0>;

> > For example, the "battery_product_index" property here is undocumented.

> now on hikey, we only enable hi655x-regulator-pmic function, and
> regulator is child node of pmic.do i need to document regulator
> dt-binding in this file or create a new regulator dt-binding file?

Either is possible, though it is common to split the DT documentation
into per subsystem files for ease of reference and to avoid cross tree
merge issues.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)