linux-kernel - Re: [PATCH 1/1] x86/io_apic: suppress compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56172888.90005@linux.intel.com>
Date:	Fri, 9 Oct 2015 10:38:00 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH 1/1] x86/io_apic: suppress compiler warning

On 2015/10/8 23:55, Andy Shevchenko wrote:
> We have to define internally used function as static, otherwise the following
> warning will be generated:
> 
> arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Hi Andy,
	Thanks for fixing this.
Reviewed-by: Jiang Liu <jiang.liu@...ux.intel.com>

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  arch/x86/kernel/apic/io_apic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 5c60bb1..b5a0e3c 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
>  	}
>  }
>  
> -void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
> +static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
>  {
>  	unsigned long flags;
>  	struct irq_pin_list *entry;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/