linux-kernel - Re: [PATCH v2 1/1] x86/early_printk: Use _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Oct 2015 17:35:12 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for
 IO

On Fri, 2015-10-09 at 17:29 +0300, Andy Shevchenko wrote:
> There are following warnings on unpatched code:
> 
> arch/x86/kernel/early_printk.c:198:32: warning: incorrect type in 
> initializer (different address spaces)
> arch/x86/kernel/early_printk.c:198:32:    expected void [noderef] 
> <asn:2>*vaddr
> arch/x86/kernel/early_printk.c:198:32:    got unsigned int [usertype] 
> *<noident>
> arch/x86/kernel/early_printk.c:205:32: warning: incorrect type in 
> initializer (different address spaces)
> arch/x86/kernel/early_printk.c:205:32:    expected void [noderef] 
> <asn:2>*vaddr
> arch/x86/kernel/early_printk.c:205:32:    got unsigned int [usertype] 
> *<noident>

This one is wrong, sorry for noise.

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2:
> - amend subject line
>  arch/x86/kernel/early_printk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early_printk.c 
> b/arch/x86/kernel/early_printk.c
> index 076a4a7..77f2f5c 100644
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -195,14 +195,14 @@ static __init void early_serial_init(char *s)
>  #ifdef CONFIG_PCI
>  static void mem32_serial_out(unsigned long addr, int offset, int 
> value)
>  {
> -	u32 *vaddr = (u32 *)addr;
> +	void __iomem *vaddr = (void __iomem *)addr;
>  	/* shift implied by pointer type */
>  	writel(value, vaddr + offset);
>  }
>  
>  static unsigned int mem32_serial_in(unsigned long addr, int offset)
>  {
> -	u32 *vaddr = (u32 *)addr;
> +	void __iomem *vaddr = (void __iomem *)addr;
>  	/* shift implied by pointer type */
>  	return readl(vaddr + offset);
>  }

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/