linux-kernel - Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151009145414.GU7340@mwanda>
Date:	Fri, 9 Oct 2015 17:54:14 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Tillmann Heidsieck <theidsieck@...nox.de>
Cc:	devel@...verdev.osuosl.org, florian.c.schilhabel@...glemail.com,
	Punit Vara <punitvara@...il.com>, stillcompiling@...il.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Joe Perches <joe@...ches.com>, dogukan.ergun@...il.com,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to
 right side of the comparision

On Wed, Sep 30, 2015 at 12:34:33PM +0300, Dan Carpenter wrote:
> On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote:
> > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote:
> > > The primary requirement for moving a driver out of staging is that it use
> > > mac80211. No amount of cosmetic fixing will ever make that change for
> > > rtl8712u!
> > 
> > As I am pretty sure someone has done something like this before, is
> > there a best practice write-up on this? Or a driver that is recommended
> > for usage as a template?
> 
> That's a good question.  The rtl* drivers are basically a dozen copies
> of the same code.  I think we have had a few escape from staging?
> 

There have several realtek drivers which have escaped staging.  All of
them seem to have been re-writes from scratch.  Three of them were wifi
drivers.

rtl8187se: 5ed0a8e66709 ('staging: delete rtl8187se wireless driver')
rtl8192ee: f823182bc289 ('staging: r8192ee: Remove staging driver')
rtl8821ae: 76272ab3f348 ('staging: rtl8821ae: remove driver')

It feels like cleaning up rtl drivers is a waste of time except for the
churn.  Staging was deliberately designed to encourage churn so that a
lot of newbies could get experience sending patches.  It would have been
easy enough to run new drivers through checkpatch.pl --fix or whatever
but churn was part of the point from square one.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/