linux-kernel - Re: arm/arm64: GICv2 driver does not have irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1510091951250.6097@nanos>
Date:	Fri, 9 Oct 2015 19:52:49 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Duc Dang <dhdang@....com>
cc:	Marc Zyngier <marc.zyngier@....com>,
	Jason Cooper <jason@...edaemon.net>,
	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	patches <patches@....com>
Subject: Re: arm/arm64: GICv2 driver does not have irq_disable implemented

On Fri, 9 Oct 2015, Duc Dang wrote:
> Hi Thomas, Marc, Jason and All,
> 
> In APM ARM64 X-Gene Enet controller driver, we use disable_irq_nosync to
> disable interrupt before calling __napi_schedule to schedule packet handler
> to process the Tx/Rx packets.

Which is wrong to begin with. Disable the interrupt at the device
level not at the interrupt line level.
 
Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/