| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADaLNDmgWnOAugY20nXWz_-2m-KPKnARMWeYMDTuPdRe8SA8sQ@mail.gmail.com> Date: Fri, 9 Oct 2015 13:45:47 -0700 From: Duc Dang <dhdang@....com> To: Thomas Gleixner <tglx@...utronix.de> Cc: Marc Zyngier <marc.zyngier@....com>, Jason Cooper <jason@...edaemon.net>, linux-arm <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, patches <patches@....com> Subject: Re: arm/arm64: GICv2 driver does not have irq_disable implemented On Fri, Oct 9, 2015 at 10:52 AM, Thomas Gleixner <tglx@...utronix.de> wrote: > On Fri, 9 Oct 2015, Duc Dang wrote: >> Hi Thomas, Marc, Jason and All, >> >> In APM ARM64 X-Gene Enet controller driver, we use disable_irq_nosync to >> disable interrupt before calling __napi_schedule to schedule packet handler >> to process the Tx/Rx packets. > > Which is wrong to begin with. Disable the interrupt at the device > level not at the interrupt line level. > Hi Thomas, We could not disable the interrupt at Enet controller level due to the controller limitation. As you said, using disable_irq_nosync is wrong but it looks like that the only option that we have. Do you have any suggestion about different approach that we could try? > Thanks, > > tglx Regards, Duc Dang. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists