linux-kernel - Re: [PATCH] i2c: return probe deferred status on dev_pm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151012072312.GB1477@katana>
Date:	Mon, 12 Oct 2015 08:23:12 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Kieran Bingham <kieranbingham@...il.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach

Hi Kiera,

On Sun, Oct 11, 2015 at 12:39:31PM +0100, Kieran Bingham wrote:
> A change of return status was introduced in commit 3fffd1283927
> ("i2c: allow specifying separate wakeup interrupt in device tree")

Thanks for catching this!

> The commit prevents the defer status being passed up the call stack
> appropriately when dev_pm_domain_attach returns -EPROBE_DEFER.
> 
> To fix we change this back to the original return status;

What about going to the error path?

> Signed-off-by: Kieran Bingham <kieranbingham@...il.com>

Please add a "Fixes: <sha1>" tag here.

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)