linux-kernel - Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151012075001.GB3558@piout.net>
Date:	Mon, 12 Oct 2015 09:50:01 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Sylvain Rochet <sylvain.rochet@...secur.com>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	linux-arm-kernel@...ts.infradead.org,
	Wenyou Yang <wenyou.yang@...el.com>,
	Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device
 tree first

Hi Sylvain,

The rest of the series looks good to me, one comment below:

On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote :
> watchdog_init_timeout function doesn't try to get the "timeout-sec" DT
> property if timeout_parm is not zero. This change makes this DT property
> working for the sama5d4 watchdog driver.
> 

While I'm not sure of the feasibility, I think that the module parameter
should override the DT property.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/