linux-kernel - Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444771677.16434.0.camel@vtpm2014.ibm.com>
Date:	Tue, 13 Oct 2015 17:27:57 -0400
From:	"Hon Ching(Vicky) Lo" <honclo@...ux.vnet.ibm.com>
To:	Ashley Lai <ashleydlai@...il.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <PeterHuewe@....de>,
	Ashley Lai <ashley@...leylai.com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Vicky Lo <honclo2014@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned


On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote:
> 
> On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote:
> > The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
> > This patch reformats the log to be byte-aligned for the Linux client.
> >
> > Signed-off-by: Hon Ching(Vicky) Lo <honclo@...ux.vnet.ibm.com>
> > ---
> >   arch/powerpc/kernel/prom_init.c |   13 ++++++++++++-
> >   1 files changed, 12 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> > index b9b6bb1..8a5c248 100644
> > --- a/arch/powerpc/kernel/prom_init.c
> > +++ b/arch/powerpc/kernel/prom_init.c
> > @@ -1417,8 +1417,9 @@ static void __init prom_instantiate_sml(void)
> >   {
> >   	phandle ibmvtpm_node;
> >   	ihandle ibmvtpm_inst;
> > -	u32 entry = 0, size = 0;
> > +	u32 entry = 0, size = 0, succ = 0;
> >   	u64 base;
> > +	__be32 val;
> >   
> >   	prom_debug("prom_instantiate_sml: start...\n");
> >   
> > @@ -1433,6 +1434,16 @@ static void __init prom_instantiate_sml(void)
> >   		return;
> >   	}
> >   
> > +	if (prom_getprop(ibmvtpm_node, "ibm,sml-efi-reformat-supported",
> > +			 &val, sizeof(val)) != PROM_ERROR) {
> > +		if (call_prom_ret("call-method", 2, 2, &succ,
> > +				  ADDR("reformat-sml-to-efi-alignment"),
> > +				  ibmvtpm_inst) != 0 || succ == 0) {
> 
> reformat-sml-to-efi-alignment is something new just added in the firmware?  I don't remember seeing it before.

Yes, it's new.  Our new firmware version will support it.

> 
> 
> > +			prom_printf("Reformat SML to EFI alignment failed\n");
> > +			return;
> > +		}
> > +	}
> > +
> >   	if (call_prom_ret("call-method", 2, 2, &size,
> >   			  ADDR("sml-get-handover-size"),
> >   			  ibmvtpm_inst) != 0 || size == 0) {
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/