| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Oct 2015 20:33:43 +0300 From: Alexander Kapshuk <alexander.kapshuk@...il.com> To: linux-kernel <linux-kernel@...r.kernel.org> Cc: Jim Davis <jim.epost@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, richard@....at, "Theodore Ts'o" <tytso@....edu> Subject: Re: [PATCH 22/22] ver_linux: proc/modules, limit text processing to 'sed' On Mon, Oct 12, 2015 at 11:22 PM, Jim Davis <jim.epost@...il.com> wrote: > On Mon, Oct 12, 2015 at 11:40 AM, Alexander Kapshuk > <alexander.kapshuk@...il.com> wrote: >> This patch is more of a personal preference, rather than a fix for a problem. > > Using the sed hold space isn't exactly easy to follow... if, unlike > the other patches, there isn't some potential improvement over the > status quo I'd suggest sticking with the original version. > > -- > Jim Thanks for your feedback. If the use of a shell variable to store the generated list of modules be deemed more favourable than the use of the 'sed' hold space, may I at least suggest either of the two approaches below: Sorted list: Y=`sort /proc/modules | sed 's/ .*$//'` Unsorted list: Z=`sed 's/ .*$//' /proc/modules` The use of 'cat' in the context of the original implementation is redundant. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists