linux-kernel - Re: [PATCH 01/22] ver_linux: gcc -dumpversion, use regex to find version number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+r1ZhiBbwvthNiGmpOxnRQUbayC7Z6K9Fgea3KntsFGEwx5Kg@mail.gmail.com>
Date:	Wed, 14 Oct 2015 14:43:38 -0700
From:	Jim Davis <jim.epost@...il.com>
To:	Alexander Kapshuk <alexander.kapshuk@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	richard@....at, "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH 01/22] ver_linux: gcc -dumpversion, use regex to find
 version number

On Wed, Oct 14, 2015 at 2:29 AM, Alexander Kapshuk
<alexander.kapshuk@...il.com> wrote:
> On Wed, Oct 14, 2015 at 2:21 AM, Jim Davis <jim.epost@...il.com> wrote:
>> I tried out patches 1-22 on a Fedora 22 system with the v4.3-rc5
>> source tree; everything looks pretty good.  The old ver_linux script
>> didn't get the mount version right, but the new one does
>>
>> < mount                  debug
>>> Mount            2.26.2
>>
>> One minor thing with Net-tools, the old version printed
>>
>> < Net-tools              2.10-alpha
>>
>> while the regex the in the new version skips the '-alpha'
>>
>>> Net-tools        2.10
>>
>> Though I'm not a big fan of patch 22 (the sed hold space thing) there
>> are several nice improvements all in all.
>>
>> --
>> Jim
>
> Thanks very much for reviewing the patches and for your commentary.

You're welcome, but I think you may need to run checkpatch -- from a
quick test there were a few minor whitespace issues.

-- 
Jim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/