[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151202072725.GA26580@amd>
Date: Wed, 2 Dec 2015 15:24:45 +0100
From: Pavel Machek <pavel@....cz>
To: Alexander Kapshuk <alexander.kapshuk@...il.com>
Cc: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
jim.epost@...il.com, richard@....at, tytso@....edu
Subject: Re: [PATCH 01/22] ver_linux: gcc -dumpversion, use regex to find
version number
On Mon 2015-10-12 21:39:41, Alexander Kapshuk wrote:
> Rely on regex to find the version number, rather than a field
number.
Are you sure that is good idea?
I'd say that the field number is going to fail in more obvious way,
which is a good thing.
Pavel
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@...il.com>
> ---
> scripts/ver_linux | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/ver_linux b/scripts/ver_linux
> index 7de36df..af6467e 100755
> --- a/scripts/ver_linux
> +++ b/scripts/ver_linux
> @@ -11,8 +11,12 @@ echo ' '
> uname -a
> echo ' '
>
> -gcc -dumpversion 2>&1| awk \
> -'NR==1{print "Gnu C ", $1}'
> +gcc -dumpversion 2>&1 |
> +awk '/[0-9]+([.]?[0-9]+)+/ && !/not found$/{
> + match($0, /[0-9]+([.]?[0-9]+)+/)
> + printf("GNU C\t\t\t%s\n",
> + substr($0,RSTART,RLENGTH))
> +}'
>
> make --version 2>&1 | awk -F, '{print $1}' | awk \
> '/GNU Make/{print "Gnu make ",$NF}'
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists