linux-kernel - Re: [PATCH v3 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151202142515.GA7404@rob-hp-laptop>
Date:	Wed, 2 Dec 2015 08:25:15 -0600
From:	Rob Herring <robh@...nel.org>
To:	Liviu Dudau <Liviu.Dudau@....com>
Cc:	David Airlie <airlied@...ux.ie>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Sudeep Holla <sudeep.holla@....com>,
	Jon Medhurst <tixy@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>, Arnd Bergmann <arnd@...db.de>,
	Olof Johansson <olof@...om.net>,
	Punit Agrawal <punit.agrawal@....com>,
	DRI devel <dri-devel@...ts.freedesktop.org>,
	devicetree <devicetree@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] drm: arm: Add DT bindings documentation for HDLCD
 driver.

On Wed, Dec 02, 2015 at 12:22:59PM +0000, Liviu Dudau wrote:
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Kumar Gala <galak@...eaurora.org>
> 
> Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>

I still think you should have a more specific compatible string, but 
here's some rope:

Acked-by: Rob Herring <robh@...nel.org>

> ---
>  .../devicetree/bindings/display/arm,hdlcd.txt      | 79 ++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/arm,hdlcd.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/arm,hdlcd.txt b/Documentation/devicetree/bindings/display/arm,hdlcd.txt
> new file mode 100644
> index 0000000..78bc242
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/arm,hdlcd.txt
> @@ -0,0 +1,79 @@
> +ARM HDLCD
> +
> +This is a display controller found on several development platforms produced
> +by ARM Ltd and in more modern of its' Fast Models. The HDLCD is an RGB
> +streamer that reads the data from a framebuffer and sends it to a single
> +digital encoder (DVI or HDMI).
> +
> +Required properties:
> +  - compatible: "arm,hdlcd"
> +  - reg: Physical base address and length of the controller's registers.
> +  - interrupts: One interrupt used by the display controller to notify the
> +    interrupt controller when any of the interrupt sources programmed in
> +    the interrupt mask register have activated.
> +  - clocks: A list of phandle + clock-specifier pairs, one for each
> +    entry in 'clock-names'.
> +  - clock-names: A list of clock names. For HDLCD it should contain:
> +      - "pxlclk" for the clock feeding the output PLL of the controller.
> +
> +Required sub-nodes:
> +  - port: The HDLCD connection to an encoder chip. The connection is modeled
> +    using the OF graph bindings specified in
> +    Documentation/devicetree/bindings/graph.txt.
> +
> +Optional properties:
> +  - memory-region: phandle to a node describing memory (see
> +    Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt) to be
> +    used for the framebuffer; if not present, the framebuffer may be located
> +    anywhere in memory.
> +
> +
> +Example:
> +
> +/ {
> +	...
> +
> +	hdlcd@...00000 {
> +		compatible = "arm,hdlcd";
> +		reg = <0 0x2b000000 0 0x1000>;
> +		interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&oscclk5>;
> +		clock-names = "pxlclk";
> +		port {
> +			hdlcd_output: endpoint@0 {
> +				remote-endpoint = <&hdmi_enc_input>;
> +			};
> +		};
> +	};
> +
> +	/* HDMI encoder on I2C bus */
> +	i2c@...a0000 {
> +		....
> +		hdmi-transmitter@70 {
> +			compatible = ".....";
> +			reg = <0x70>;
> +			port@0 {
> +				hdmi_enc_input: endpoint {
> +					remote-endpoint = <&hdlcd_output>;
> +				};
> +
> +				hdmi_enc_output: endpoint {
> +					remote-endpoint = <&hdmi_1_port>;
> +				};
> +			};
> +		};
> +
> +	};
> +
> +	hdmi1: connector@1 {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +		port {
> +			hdmi_1_port: endpoint {
> +				remote-endpoint = <&hdmi_enc_output>;
> +			};
> +		};
> +	};
> +
> +	...
> +};
> -- 
> 2.6.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/