linux-kernel - Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151014132050.GK32409@x1>
Date:	Wed, 14 Oct 2015 14:20:50 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	cw00.choi@...sung.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, myungjoo.ham@...sung.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for
 mic detection

On Wed, 14 Oct 2015, Mark Brown wrote:

> On Wed, Oct 14, 2015 at 01:30:14PM +0100, Lee Jones wrote:
> > On Wed, 14 Oct 2015, Mark Brown wrote:
> 
> > > > Not necessarily _your_ review.  Just someone, other than the
> > > > submitter, who I trust and knows about this stuff.  You just happen 
> > > > to tick those boxes this time.  Cross pollination and knowledge sharing
> > > > is one of the characteristics of MLs which I'm particularly proud of.
> 
> > > That was what it read like.
> 
> ...
> 
> > > So, a more specific question would have helped - just a general "any
> > > thoughts" type question isn't very clear.
> 
> > To both comments -- this is how I phrased it:
> 
> > "I either need an Ack from the DT folks, or at least someone who knows
> > about this stuff.  Mark perhaps."
> 
> I'd have expected something that says why you're looking for this -
> something saying what you were unclear on, something more like "It seems
> like there's an awful lot of properties for something that just checks
> if a jack".  From the above (especially with the request for the DT
> people to review) it seems like more just a review because there's DT
> properties.

Your perception is not correct.  I always used to ask for a DT review
if there are more than a couple being added.  These days I'm happy to
apply either complex properties, or just ones I'm not 100% on with a
suitable Maintainer Ack.  That continues to be the case.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/