linux-kernel - Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014130920.GW14956@sirena.org.uk>
Date:	Wed, 14 Oct 2015 14:09:20 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	cw00.choi@...sung.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, myungjoo.ham@...sung.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for
 mic detection

On Wed, Oct 14, 2015 at 01:30:14PM +0100, Lee Jones wrote:
> On Wed, 14 Oct 2015, Mark Brown wrote:

> > > Not necessarily _your_ review.  Just someone, other than the
> > > submitter, who I trust and knows about this stuff.  You just happen 
> > > to tick those boxes this time.  Cross pollination and knowledge sharing
> > > is one of the characteristics of MLs which I'm particularly proud of.

> > That was what it read like.

...

> > So, a more specific question would have helped - just a general "any
> > thoughts" type question isn't very clear.

> To both comments -- this is how I phrased it:

> "I either need an Ack from the DT folks, or at least someone who knows
> about this stuff.  Mark perhaps."

I'd have expected something that says why you're looking for this -
something saying what you were unclear on, something more like "It seems
like there's an awful lot of properties for something that just checks
if a jack".  From the above (especially with the request for the DT
people to review) it seems like more just a review because there's DT
properties.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)