linux-kernel - Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014165031.GA32274@infradead.org>
Date:	Wed, 14 Oct 2015 09:50:31 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Keith Busch <keith.busch@...el.com>
Cc:	Christoph Hellwig <hch@...radead.org>, Ming Lin <mlin@...nel.org>,
	Jens Axboe <axboe@...nel.dk>,
	Ming Lin <ming.l@....samsung.com>,
	Mike Snitzer <snitzer@...hat.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-nvme@...ts.infradead.org, Dongsu Park <dpark@...teo.net>,
	Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: [PATCH v6 05/11] block: remove split code in
 blkdev_issue_{discard,write_same}B

On Wed, Oct 14, 2015 at 04:38:50PM +0000, Keith Busch wrote:
> I see why the proposal is an improvement, but I don't understand why the
> current situation results in a hang. Are we missing some kind of error
> recovery in the driver?

The driver tries to abort the commands and eventually gets into a death
spiral.  I'm still trying to understand what exactly is going on.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/