linux-kernel - Re: [PATCH v3] selftests/seccomp: build and pass on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56203023.2060007@osg.samsung.com>
Date:	Thu, 15 Oct 2015 17:00:51 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andy Lutomirski <luto@...capital.net>,
	Will Drewry <wad@...omium.org>,
	Linux API <linux-api@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v3] selftests/seccomp: build and pass on arm64

On 10/15/2015 04:07 PM, Kees Cook wrote:
> On Thu, Oct 15, 2015 at 1:06 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
>> On 10/15/2015 12:42 PM, Kees Cook wrote:
>>> On Thu, Oct 15, 2015 at 7:07 AM, Shuah Khan <shuahkh@....samsung.com> wrote:
>>>> On 10/06/2015 01:30 PM, Kees Cook wrote:
>>>>> Changing arm64 syscalls is done via a specific register set, more like s390
>>>>> than like arm (specific ptrace call) and x86 (part of general registers).
>>>>> Since (restarting) poll doesn't exist on arm64, switch to using nanosleep
>>>>> for testing restart_syscall. And since it looks like the syscall ABI is
>>>>> inconsistent on arm-compat, so we must work around it (and document it) in
>>>>> the test.
>>>>>
>>>>> Signed-off-by: Kees Cook <keescook@...omium.org>
>>>>> ---
>>>>> v3:
>>>>>  - correctly set syscall number on native arm64.
>>>>> v2:
>>>>>  - switch to nanosleep from a bad mix of poll and ppoll for testing restart.
>>>>> ---
>>>>
>>>> Is this good to go? Failed to apply to linux-kselftest next.
>>>> If you can rebase and resend. I can get this into 4.4-rc1
>>>
>>> Yes please. :)
>>>
>>
>> ok. Please rebase to linux-kselftest next and resend the patch.
> 
> Am I looking at the right tree? linux-kselftest#next doesn't appear to
> have the s390 patch that was included in 4.3.
> 

I see what happened. Your patch is linux-next fixes and that went into
4.3-rc2. I can get linux-next rebase to 4.3-rc2 and get your patch in.
Thanks for clearing this up.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/