lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2015 11:48:12 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Marc Dietrich <marvin24@....de> Cc: gregkh@...uxfoundation.org, linux-tegra@...r.kernel.org, Sakshi Bansal <sakshi.april5@...il.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: nvec: fixed few coding style warnings On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > - if (unlikely(nvec->rx == NULL)) { > > > + if (!unlikely(nvec->rx)) { > > > > This isn't right. You intented to say: > > > > if (unlikely(!nvec->rx)) { > > > > But even better to just remove the unlikely entirely. > > > > if (!nvec->rx) { > > why? the "unlikely" is there to optimize a critical interrupt path. The rule is that drivers should not use likely/unlikely() unless there is a difference in benchmark numbers. How critical can it be when it's always followed by a udelay(100)??? There are more important optimizations needed here. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists