linux-kernel - Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151015095749.GC4267@pd.tnic>
Date:	Thu, 15 Oct 2015 11:57:49 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	dinguyen@...nsource.altera.com
Cc:	tthayer@...nsource.altera.com, dinh.linux@...il.com,
	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for
 ECC_CORR_EN

On Wed, Oct 14, 2015 at 06:14:16PM -0500, dinguyen@...nsource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
> 
> The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling
> ECC_CORR_EN, when error happens, it is the user's responsibility to perform
> a full SDRAM scrub.
> 
> Remove the check for ECC_CORR_EN.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@...nsource.altera.com>
> ---
>  drivers/edac/altera_edac.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
> index 7b64dc7..7a52585 100644
> --- a/drivers/edac/altera_edac.h
> +++ b/drivers/edac/altera_edac.h
> @@ -30,8 +30,7 @@
>  #define CV_CTLCFG_GEN_SB_ERR       0x2000
>  #define CV_CTLCFG_GEN_DB_ERR       0x4000
>  
> -#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN | \
> -				   CV_CTLCFG_ECC_CORR_EN)
> +#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN)
>  
>  /* SDRAM Controller Address Width Register */
>  #define CV_DRAMADDRW_OFST          0x2C
> -- 

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/