linux-kernel - Re: [PATCH v4 18/79] dm-log-userspace.h: use __u32, __s32 and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015175334.GB6104@lakka.kapsi.fi>
Date:	Thu, 15 Oct 2015 20:53:34 +0300
From:	Mikko Rapeli <mikko.rapeli@....fi>
To:	Mike Snitzer <snitzer@...hat.com>
Cc:	linux-kernel@...r.kernel.org, dm-devel@...hat.com,
	Alasdair Kergon <agk@...hat.com>, linux-api@...r.kernel.org
Subject: Re: [PATCH v4 18/79] dm-log-userspace.h: use __u32, __s32 and __u64
 from linux/types.h

Hi,

On Thu, Oct 15, 2015 at 04:09:50AM -0400, Mike Snitzer wrote:
> On Thu, Oct 15 2015 at  1:55am -0400,
> Mikko Rapeli <mikko.rapeli@....fi> wrote:
> 
> > Fixes userspace compilation errors like:
> > 
> > linux/dm-log-userspace.h:416:2: error: unknown type name ‘uint64_t’
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> 
> As was already explained before, there is no need to compile this for
> userspace consumption.  Where is this requirement coming from?

Sorry, maybe I did not understand this comment. Currently
include/uapi/linux/dm-log-userspace.h is in uapi headers and thus exported
to userspace and has this bug/feature which breaks a build.

Are you saying that it should not be exported to userspace at all and it
should be moved back to include/linux/dm-log.h?

I can prepare such a change instead.

> If your 0th patch's header speaks to _why_ you keep requesting this
> change then please cc me on it.

Sorry, I'm touching too many uapi headers with similar changes
so I can't Cc that many mailing lists and individuals with the cover
letter, but it is available here:

https://lkml.org/lkml/2015/10/15/22

-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/