linux-kernel - Re: [PATCH] keys: correctly check failed allocation for kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29544.1444935453@warthog.procyon.org.uk>
Date:	Thu, 15 Oct 2015 19:57:33 +0100
From:	David Howells <dhowells@...hat.com>
To:	Insu Yun <wuninsu@...il.com>
Cc:	dhowells@...hat.com, james.l.morris@...cle.com, serge@...lyn.com,
	keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu
Subject: Re: [PATCH] keys: correctly check failed allocation for kmemdup

Insu Yun <wuninsu@...il.com> wrote:

> kmemdup return value is saved in 'key->index_key.description', not
> 'key->descrption' and kmemdup can be failed in memory pressure.
> Therefore, key->index_key.description should be checked.

The fields are unioned.  It makes no difference.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/