linux-kernel - Re: [PATCH 04/20] x86: Rewrite copy_siginfo_{to,from}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 19:58:53 +0100
From:	"Amanieu d'Antras" <amanieu@...il.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, x86@...nel.org,
	Brian Gerst <brgerst@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 04/20] x86: Rewrite copy_siginfo_{to,from}_user32

On Thu, Oct 15, 2015 at 7:41 PM, Oleg Nesterov <oleg@...hat.com> wrote:
> OOH ;) I'll try to look at this patch and the changes in the generic
> code later. A couple of nits right now.
>
> Please CC x86 maintainers, not only x86@...nel.org.
>
> Please do not remove get/put_user_ex from this code. And this reminds
> me that we can improve *user_try/*user_catch ...
>
> [...snip...]
>
> the rest looks unreviewable because you didn't split it and because
> you removed try/catch ;) The same for copy-from-user.
>
> Please help us to understand these changes and make the more reviewable
> patches if possible. Personally I think you have a point.

What I did here was replace the old x86-specific version with the
generic version, which I then modified to support x32. If you compare
it with the generic version, the only difference is the addition of
the ia32 flag. The intent was to make it as close as possible to the
generic version, which makes it easier to update both at the same time
when a new siginfo_t fields is added.

This is also why I didn't use put_user_try/get_user_try: it would make
the x86 version unnecessarily diverge from the generic version, since
those macros only exist in the x86 architecture.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/