linux-kernel - Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 11:28:46 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Franklin S Cooper Jr <fcooper@...com>
Cc:	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	nsekhar@...com, ssantosh@...nel.org, iivanov@...sol.com,
	m-karicheri2@...com, iivanov.xz@...il.com,
	andy.shevchenko@...il.com, jarkko.nikula@...ux.intel.com,
	hkallweit1@...il.com
Subject: Re: [PATCH] spi: Setup the master controller driver before setting
 the chipselect

On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote:
> Some devices depend on the master controller driver setup function being
> called before calling any chipselect functions.
> 
> Insure that this is done otherwise uninitialized structures may be
> accessed causing a kernel panic.

I think this is a sensible change but can we please have a better
changelog - why is this the best thing to do rather than fixing the
driver to not crash?  There are a bunch of good reasons to do the master
setup before asserting chip select but a driver crashing isn't one of
them, it's not clear that this isn't a bug in the driver.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)