linux-kernel - Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56210966.3040501@ti.com>
Date:	Fri, 16 Oct 2015 09:27:50 -0500
From:	"Franklin S Cooper Jr." <fcooper@...com>
To:	Mark Brown <broonie@...nel.org>
CC:	<linux-kernel@...r.kernel.org>, <linux-spi@...r.kernel.org>,
	<nsekhar@...com>, <ssantosh@...nel.org>, <iivanov@...sol.com>,
	<m-karicheri2@...com>, <iivanov.xz@...il.com>,
	<andy.shevchenko@...il.com>, <jarkko.nikula@...ux.intel.com>,
	<hkallweit1@...il.com>
Subject: Re: [PATCH] spi: Setup the master controller driver before setting
 the chipselect



On 10/16/2015 05:28 AM, Mark Brown wrote:
> On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote:
>> Some devices depend on the master controller driver setup function being
>> called before calling any chipselect functions.
>>
>> Insure that this is done otherwise uninitialized structures may be
>> accessed causing a kernel panic.
> I think this is a sensible change but can we please have a better
> changelog - why is this the best thing to do rather than fixing the
> driver to not crash?  There are a bunch of good reasons to do the master
> setup before asserting chip select but a driver crashing isn't one of
> them, it's not clear that this isn't a bug in the driver.
Mark,
Makes sense. How about something like this?

SPI controllers may need to be properly setup before chip selects
can be used. Therefore, wait until the spi controller has a chance
to perform their setup procedure before trying to use the chip
select.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/