linux-kernel - Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151016144305.GO14956@sirena.org.uk>
Date:	Fri, 16 Oct 2015 15:43:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Franklin S Cooper Jr." <fcooper@...com>
Cc:	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	nsekhar@...com, ssantosh@...nel.org, iivanov@...sol.com,
	m-karicheri2@...com, iivanov.xz@...il.com,
	andy.shevchenko@...il.com, jarkko.nikula@...ux.intel.com,
	hkallweit1@...il.com
Subject: Re: [PATCH] spi: Setup the master controller driver before setting
 the chipselect

On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:

> Makes sense. How about something like this?

> SPI controllers may need to be properly setup before chip selects
> can be used. Therefore, wait until the spi controller has a chance
> to perform their setup procedure before trying to use the chip
> select.

Yes, that's a lot better - there's also the fact that if we assert chip
select before we've got the pins in a good state we may cause the device
to see signals that confuse it as we change.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)